Allow key bindings customization #11
Conversation
|
Hi @tesfabpel 👋 Keybindings have already been discussed in this issue (#7) and was deemed to add too much complexity to the project. That is of course unless @sburris0 has changed his opinion on this. |
tesfabpel
force-pushed
the
key-config
branch
from
ec561cd
to
1a4b378
Compare
|
@BlackPhlox @sburris0 Not having key bindings is unnecessarily limiting. Here I am, making a branch of this project solely because of this reason. Please reconsider this decision, if only for the purpose of international use. |
|
@TheCarpetMerchant I'll follow up on this Sunday, giving Spencer some time to respond to this. |
|
I hadn't considered international use. I agree this is worthwhile to help non-US keyboard users
Dec 15, 2022 8:52:55 AM TheCarpetMerchant ***@***.***>:
… @BlackPhlox[https://github.com/BlackPhlox] @sburris0[https://github.com/sburris0] Not having key bindings is unnecessarily limiting. Here I am, making a branch of this project solely because of this reason. Please reconsider this decision, if only for the purpose of international use.
There does not need to be added complexity, as Key bindings could simply be added to *MovementSettings*, with WASD as the default.
If you do not which to change *MovementSettings*, creating a simple *KeyBindings* struct used as a resource and used in *player_move* is perfectly fine too.
—
Reply to this email directly, view it on GitHub[#11 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AN3IJED6RJPAU7WNJ4FCZLDWNNEGLANCNFSM5HY4RSQA].
You are receiving this because you were mentioned.[Tracking image][https://github.com/notifications/beacon/AN3IJEBKWGIXQZCHBPE2AW3WNNEGLA5CNFSM5HY4RSQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOKCVSQZA.gif]
|
|
Cool, I'll see if I can merge the changes since this pr was made prior to 0.9 |
Hi,
I added a (very) simple way to configure key bindings.
I hope I did everything alright.